-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YUNIKORN-2151 Report resource used by placeholder pods in the app su… #715
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #715 +/- ##
==========================================
- Coverage 77.65% 77.64% -0.01%
==========================================
Files 80 80
Lines 13339 13344 +5
==========================================
+ Hits 10358 10361 +3
- Misses 2658 2660 +2
Partials 323 323 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nits (one question actually).
Hi @pbacsko , i addressed your comments and also fix all the time sleep for tracking resources. |
@zhuqi-lucas as I mentioned in the JIRA, pls check TestFinishedTime. Thanks. |
Addressed this, thanks @pbacsko ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
…mmary
What is this PR for?
YUNIKORN-1385 reports resource usage of application upon its completion.
The app summary should also consider the placeholder pods, which can be timeout for default 15 mins, but we can't count the resource used by placeholder pods.
What type of PR is it?
Todos
What is the Jira issue?
[YUNIKORN-2] Gang scheduling interface parameters
How should this be tested?
Screenshots (if appropriate)
Questions: